Video Block: add raw transformation from video html
#47159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +157 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
enhancement/video-block-raw-transform
branch
from
78b2f7f
to
3a1c0ab
Compare
|
Flaky tests detected in 78b2f7f55549a9fe65cae9e8e39a13d531221061. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3917556873
|
t-hamano
force-pushed
the
enhancement/video-block-raw-transform
branch
2 times, most recently
from
b61be71
to
5276f01
Compare
t-hamano
force-pushed
the
enhancement/video-block-raw-transform
branch
from
5276f01
to
32d3081
Compare
Mamaduka
approved these changes
Jan 15, 2024
|
Thanks for the review, @Mamaduka! Just to be sure, I would like to merge the latest trunk into this PR, test it again, and if there are no problems, I would like to merge it. |
|
Thanks for implementing a fix for this! I had a local transformation in place which achieved similar, but also added |
|
@codebymikey Thank you for your great exploration! I created a test page and tried your code, but it didn't work. From what I've researched, the Clipboard API doesn't seem to recognize either 517516a7931c901b93b4caaf10a6e807.mp4 |
|
On further investigation, it seems to be because of the way the transform works, the gutenberg/packages/dom/src/phrasing-content.js Lines 113 to 125 in 23c3a67 to be similar to this And re the Clipboard API: it's more for if you copy the actual HTML source (with sources and tracks) into the editor rather than for rendered videos. You ideally shouldn't lose that information on paste. |
|
Thank you for your explanation. It seems that other blocks can correctly convert HTML strings. Regarding the Video block, we may be able to deal with it through follow-up. 2f1b61ffb5c99ac0d7667486f4bc7dd8.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #42768
What?
This PR adds a transformation that generates a video block from HTML containing a
videoelement.Why?
Since
core/imageandcore/embedsupport transformation from raw HTML, it would make sense to add similar support for the video block.How?
Inherits as many attributes supported by the Video block as possible, including the
srcattribute of thevideoelement. However, thesrcattribute is assumed to be attached to thevideotag, and thesourcetag inside thevideotag is not considered.This is because the Clipboard API itself doesn't seem to pick up elements inside the
videotag. The screencast below shows that when you copy HTML containing avideoelement with asourceelement, the clipboard does not contain thesourceelement.008e760e11bb165547d74eab80e1a6bc.mp4
Testing Instructions
Screencast
7e54473e3614b35c5414b8b194d0286a.mp4